feat(cubestore): Correct orphaned detection + optimizations #6051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
commented
Jan 24, 2023
| .into_iter() | ||
| .filter(|item| item.get_row().status == status_filter) | ||
| .collect() | ||
| let index_key = QueueItemIndexKey::ByPrefixAndStatus(prefix, status_filter); |
Member
Author
There was a problem hiding this comment.
Changed to improve Performance: Usage of index
ovr
commented
Jan 24, 2023
| |item| { | ||
| let mut new = item.clone(); | ||
| new.status = QueueItemStatus::Active; | ||
| let mut new = id_row.get_row().clone(); |
Member
Author
There was a problem hiding this comment.
Changed to improve Performance: update_with_fn do an additional lookup.
ovr
commented
Jan 24, 2023
| let mut new = id_row.get_row().clone(); | ||
| new.update_heartbeat(); | ||
|
|
||
| queue_schema.update(id_row.id, new, id_row.get_row(), batch_pipe)?; |
Member
Author
There was a problem hiding this comment.
Changed to improve Performance: update_with_fn do an additional lookup.
waralexrom
approved these changes
Jan 24, 2023
ovr
force-pushed
the
cubestore-heartbeat-fix
branch
from
e3f3e62 to
a29a9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
refs #5042
Thanks