Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Feb 2, 2023

Hello!

image

Thanks

@ovr ovr requested a review from a team as a code owner February 2, 2023 14:29
@ovr ovr changed the title fix(native): Try to catch panic reason as String fix(native): Try to catch panic's reason as String Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 41.61% // Head: 62.00% // Increases project coverage by +20.38% 🎉

Coverage data is based on head (fbfecd8) compared to base (1f10c8a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6107       +/-   ##
===========================================
+ Coverage   41.61%   62.00%   +20.38%     
===========================================
  Files         152      291      +139     
  Lines       20106    40296    +20190     
  Branches     5244     5244               
===========================================
+ Hits         8368    24987    +16619     
- Misses      11428    14999     +3571     
  Partials      310      310               
Flag Coverage Δ
cube-backend 41.61% <ø> (ø)
cubesql 82.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/error.rs 17.02% <0.00%> (ø)
rust/cubesql/cubesql/src/sql/auth_service.rs 77.77% <0.00%> (ø)
...cubesql/cubesql/src/compile/test/rewrite_engine.rs 0.00% <0.00%> (ø)
...ngine/information_schema/postgres/pg_constraint.rs 97.93% <0.00%> (ø)
rust/cubesql/pg-srv/src/lib.rs 66.66% <0.00%> (ø)
...ql/src/sql/database_variables/mysql/global_vars.rs 100.00% <0.00%> (ø)
rust/cubesql/cubesql/e2e/tests/utils.rs 100.00% <0.00%> (ø)
.../cubesql/cubeclient/src/models/v1_meta_response.rs 0.00% <0.00%> (ø)
...formation_schema/postgres/pg_statio_user_tables.rs 93.93% <0.00%> (ø)
...mpile/engine/information_schema/mysql/variables.rs 92.30% <0.00%> (ø)
... and 130 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr merged commit c8cf300 into master Feb 2, 2023
@ovr ovr deleted the cubesql-reason-string branch February 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants