feat(server-core, query-orchestrator): sql-runner - supp… #6142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
2 times, most recently
from
8e73387 to
409522b
Compare
wolfeeeg
commented
Feb 10, 2023
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
2 times, most recently
from
2af913c to
7019384
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6142 +/- ##
===========================================
- Coverage 68.14% 42.76% -25.38%
===========================================
Files 301 153 -148
Lines 49738 20238 -29500
Branches 5196 5196
===========================================
- Hits 33892 8655 -25237
+ Misses 15013 10750 -4263
Partials 833 833
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 148 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
wolfeeeg
commented
Feb 14, 2023
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
2 times, most recently
from
26676ba to
38344bd
Compare
wolfeeeg
changed the title
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
from
38344bd to
0114c59
Compare
buntarb
suggested changes
Mar 6, 2023
packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts
Outdated
Show resolved
Hide resolved
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
2 times, most recently
from
9bf22a1 to
d062179
Compare
added 3 commits
March 17, 2023 10:58
…ort running queries against extDb
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
from
d062179 to
0b50e78
Compare
wolfeeeg
force-pushed
the
sql-runner-ext-db
branch
from
0b50e78 to
7ce5942
Compare
buntarb
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ort running queries against extDb
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]