Skip to content

Conversation

@hehex9
Copy link
Contributor

@hehex9 hehex9 commented Feb 28, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This pr replaces the deprecated @hapi/joi with joi package.

image

@hehex9 hehex9 requested review from a team as code owners February 28, 2023 07:39
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -42.66 ⚠️

Comparison is base (42f54ae) 85.17% compared to head (2351ce1) 42.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6223       +/-   ##
===========================================
- Coverage   85.17%   42.52%   -42.66%     
===========================================
  Files         148      153        +5     
  Lines       29447    20172     -9275     
  Branches        0     5054     +5054     
===========================================
- Hits        25082     8578    -16504     
- Misses       4365    11278     +6913     
- Partials        0      316      +316     
Flag Coverage Δ
cube-backend 42.52% <75.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/query.js 76.47% <60.00%> (ø)
...bejs-schema-compiler/src/compiler/CubeValidator.js 96.82% <100.00%> (ø)
...ges/cubejs-server-core/src/core/optionsValidate.ts 100.00% <100.00%> (ø)
...ile/engine/information_schema/postgres/pg_stats.rs
...l/src/sql/database_variables/mysql/session_vars.rs
.../cubesql/cubeclient/src/models/v1_meta_response.rs
...pile/engine/information_schema/postgres/pg_enum.rs
...mpile/engine/information_schema/postgres/tables.rs
rust/cubesql/cubesql/e2e/tests/basic.rs
.../compile/engine/information_schema/mysql/tables.rs
... and 294 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hehex9
Copy link
Contributor Author

hehex9 commented Mar 3, 2023

Hi team, I hope this message finds you well. I wanted to inquire if there's anything I can do to help move this PR forward. I would be grateful for any guidance or feedback you could provide. Thank you for your time and consideration.

@paveltiunov paveltiunov self-assigned this Mar 4, 2023
@paveltiunov
Copy link
Member

@hehex9 Thanks for contributing! Looks good to me!

@paveltiunov paveltiunov merged commit ccbcc50 into cube-js:master Mar 4, 2023
@hehex9 hehex9 deleted the @hehe/joi branch March 7, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants