Skip to content

feat(cubestore): RocksStore - panic protection for RW loop #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat(cubestore): RocksStore - panic protection for RW loop #6293

merged 1 commit into from
Mar 15, 2023

Conversation

@ovr
Copy link
Member

@ovr ovr commented Mar 14, 2023 •
edited
Loading

Hello!

Issue: Single panic in the rw loop can break the whole processing

Example:

image

mysql> cache get “1”;
ERROR 1815 (HY000): channel closed

# another operation without panic will not be processed
mysql> cache set “1" “1”;
ERROR 1815 (HY000): channel closed

Thanks

@ovr ovr requested a review from a team as a code owner March 14, 2023 21:01
ovr
ovr commented Mar 14, 2023
View reviewed changes
rust/cubestore/cubestore/src/metastore/rocks_store.rs
log::error!("Error during read write loop send: {}", e);
log::error!("Error during scheduling read task in loop: {}", e);

return Err(CubeError::internal(format!(
Copy link
Member Author

@ovr ovr Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast exit

ovr
ovr commented Mar 14, 2023
View reviewed changes
rust/cubestore/cubestore/src/metastore/rocks_store.rs
e
);

return Err(CubeError::internal(format!(
Copy link
Member Author

@ovr ovr Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast exit

@ovr ovr changed the title feat(cubestore): RocksStore - panic protection for broken rw loop feat(cubestore): RocksStore - panic protection for RW loop Mar 15, 2023
@ovr ovr merged commit 1f2db32 into master Mar 15, 2023
@ovr ovr deleted the cubestore-broken-loop branch March 15, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waralexrom waralexrom waralexrom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovr @waralexrom