Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Mar 16, 2023

….stringify pipe for streaming capability

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested review from a team as code owners March 16, 2023 00:22
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 51.51% and project coverage change: -0.04 ⚠️

Comparison is base (d74a1f0) 68.17% compared to head (ea4a85c) 68.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6306      +/-   ##
==========================================
- Coverage   68.17%   68.13%   -0.04%     
==========================================
  Files         301      301              
  Lines       49689    49738      +49     
  Branches     5196     5196              
==========================================
+ Hits        33873    33887      +14     
- Misses      14983    15018      +35     
  Partials      833      833              
Flag Coverage Δ
cube-backend 42.76% <100.00%> (-0.01%) ⬇️
cubesql 85.53% <46.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/test/mod.rs 92.00% <ø> (ø)
rust/cubesql/cubesql/src/transport/service.rs 86.48% <ø> (ø)
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 60.83% <46.66%> (-5.15%) ⬇️
...-query-orchestrator/src/orchestrator/QueryCache.ts 73.75% <100.00%> (-0.63%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit a9b19fa into master Mar 16, 2023
@paveltiunov paveltiunov deleted the writable-stream branch March 16, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants