-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs: Update join relationship types #6476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update join relationship types #6476
Conversation
|
@igorlukanin Do we have a message here that old relationship names are still valid? |
|
@keydunov Yep, here it is: |
hassankhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, great job @igorlukanin 💯
Co-authored-by: Hassan Khan <hassan@cube.dev>
Co-authored-by: Hassan Khan <hassan@cube.dev>
Thanks @igorlukanin! Can we add this message to working with joins page too? |
|
@keydunov I'm OK to do it, however, I've also updated that page (see screenshot) to have a link to the Joins page where this message is present. Do you think there would be confusion anyway? (I'd prefer keeping docs as free as possible from duplicate disclaimers, they pile up and reduce readability for new readers.) |
|
Ok, let's merge without 2nd warning. I think it should be enough, but if we see questions in the community (Slack & Github), we'd need to add more warning messages. |


No description provided.