Skip to content

Conversation

@igorlukanin
Copy link
Member

No description provided.

@igorlukanin igorlukanin requested a review from a team as a code owner April 21, 2023 19:01
@keydunov
Copy link
Member

@igorlukanin Do we have a message here that old relationship names are still valid?

@keydunov keydunov self-requested a review April 21, 2023 19:30
@igorlukanin
Copy link
Member Author

igorlukanin commented Apr 21, 2023

@keydunov Yep, here it is:

Screenshot 2023-04-21 at 21 55 38

@hassankhan hassankhan added the docs Issues that require a documentation improvement label Apr 21, 2023
Copy link
Contributor

@hassankhan hassankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, great job @igorlukanin 💯

igorlukanin and others added 2 commits April 22, 2023 16:29
Co-authored-by: Hassan Khan <hassan@cube.dev>
Co-authored-by: Hassan Khan <hassan@cube.dev>
@keydunov
Copy link
Member

@keydunov Yep, here it is:

Screenshot 2023-04-21 at 21 55 38

Thanks @igorlukanin! Can we add this message to working with joins page too?

@igorlukanin
Copy link
Member Author

@keydunov I'm OK to do it, however, I've also updated that page (see screenshot) to have a link to the Joins page where this message is present. Do you think there would be confusion anyway? (I'd prefer keeping docs as free as possible from duplicate disclaimers, they pile up and reduce readability for new readers.)

Screenshot 2023-04-24 at 15 19 13

@keydunov
Copy link
Member

Ok, let's merge without 2nd warning. I think it should be enough, but if we see questions in the community (Slack & Github), we'd need to add more warning messages.

@igorlukanin igorlukanin merged commit 47d566f into master Apr 24, 2023
@igorlukanin igorlukanin deleted the igorlukanin/edu-189-add-message-to-joins-page-that branch April 24, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants