Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented May 16, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner May 16, 2023 01:26
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 84.21% and project coverage change: +0.04 🎉

Comparison is base (8e1ab20) 47.23% compared to head (9ba1d66) 47.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6605      +/-   ##
==========================================
+ Coverage   47.23%   47.28%   +0.04%     
==========================================
  Files         154      154              
  Lines       20319    20330      +11     
  Branches     5238     5239       +1     
==========================================
+ Hits         9598     9613      +15     
+ Misses      10403    10399       -4     
  Partials      318      318              
Flag Coverage Δ
cube-backend 47.28% <84.21%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/query.js 79.25% <77.77%> (+2.78%) ⬆️
packages/cubejs-api-gateway/src/gateway.ts 63.04% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit 172c39b into master May 16, 2023
@paveltiunov paveltiunov deleted the fix-query-rewrite-limit branch May 16, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants