Skip to content

feat: Strict type validation for config #6892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: Strict type validation for config #6892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/cubejs-server-core/src/core/optionsValidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Joi from 'joi';
import DriverDependencies from './DriverDependencies';

const schemaQueueOptions = Joi.object().keys({
const schemaQueueOptions = Joi.object().strict(true).keys({
concurrency: Joi.number().min(1).integer(),
continueWaitTimeout: Joi.number().min(0).integer(),
executionTimeout: Joi.number().min(0).integer(),
Expand All @@ -11,7 +11,7 @@ const schemaQueueOptions = Joi.object().keys({
sendCancelMessageFn: Joi.func(),
});

const jwtOptions = Joi.object().keys({
const jwtOptions = Joi.object().strict(true).keys({
// JWK options
jwkRetry: Joi.number().min(1).max(5).integer(),
jwkDefaultExpire: Joi.number().min(0),
Expand Down Expand Up @@ -94,9 +94,9 @@ const schemaOptions = Joi.object().keys({
allowUngroupedWithoutPrimaryKey: Joi.boolean(),
orchestratorOptions: Joi.alternatives().try(
Joi.func(),
Joi.object().keys({
Joi.object().strict(true).keys({
redisPrefix: Joi.string().allow(''),
redisPoolOptions: Joi.object().keys({
redisPoolOptions: Joi.object().strict(true).keys({
poolMin: Joi.number().min(0),
poolMax: Joi.number().min(0),
idleTimeoutSeconds: Joi.number().min(0),
Expand Down