fix(databricks-jdbc-driver): ensure default UID property is set #7168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
MikeNitsenko
force-pushed
the
CC-3101-fix-databricks-jdbc-url-issue
branch
from
f2aa0fa to
451b6ce
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7168 +/- ##
=======================================
Coverage 47.04% 47.04%
=======================================
Files 155 155
Lines 20749 20749
Branches 5216 5216
=======================================
Hits 9761 9761
+ Misses 10671 10669 -2
- Partials 317 319 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MikeNitsenko
changed the title
MikeNitsenko
force-pushed
the
CC-3101-fix-databricks-jdbc-url-issue
branch
from
d1a31b8 to
8cb565e
Compare
paveltiunov
approved these changes
Sep 28, 2023
This was referenced Dec 14, 2023
Open
This was referenced Dec 14, 2023
This was referenced Dec 15, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not connect to Databricks by using the JDBC URL they provide.
To fix this, users have to add
UID=token.This happens because the driver is trying to use a user/password mechanism to authenticate instead of a token in the URL because we're explicitly passing the params to
getConnection()(PWD).https://github.com/cube-js/cube/blob/master/packages/cubejs-jdbc-driver/src/JDBCDriver.ts#L140