Skip to content

Conversation

@igorlukanin
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Conversation in Slack: https://cube-js.slack.com/archives/C04KDTE2EF7/p1701944283139919

Dremio docs:

@igorlukanin igorlukanin requested a review from ovr December 7, 2023 12:29
@igorlukanin igorlukanin requested a review from a team as a code owner December 7, 2023 12:29
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (065916e) 86.29% compared to head (58457b4) 48.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7503       +/-   ##
===========================================
- Coverage   86.29%   48.03%   -38.26%     
===========================================
  Files         174      154       -20     
  Lines       33820    20872    -12948     
  Branches        0     5369     +5369     
===========================================
- Hits        29185    10026    -19159     
- Misses       4635    10105     +5470     
- Partials        0      741      +741     
Flag Coverage Δ
cube-backend 48.03% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igorlukanin
Copy link
Member Author

@ovr Can we merge this one?

@ovr ovr merged commit 7e84d4c into master Dec 19, 2023
@ovr ovr deleted the dremio-driver-timestamp-fix branch December 19, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants