Skip to content

Conversation

@mharrisb1
Copy link
Contributor

Closes #7523

@mharrisb1 mharrisb1 requested a review from a team as a code owner December 13, 2023 15:26
@vercel
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 3:27pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 13, 2023
@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d87bd19) 71.68% compared to head (788b595) 48.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7527       +/-   ##
===========================================
- Coverage   71.68%   48.03%   -23.66%     
===========================================
  Files         328      154      -174     
  Lines       54726    20897    -33829     
  Branches     5380     5380               
===========================================
- Hits        39229    10037    -29192     
+ Misses      14757    10120     -4637     
  Partials      740      740               
Flag Coverage Δ
cube-backend 48.03% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit 75e201d into cube-js:master Dec 18, 2023
@ovr
Copy link
Member

ovr commented Dec 18, 2023

Thank you @mharrisb1, for your contribution 🍰

@mharrisb1 mharrisb1 deleted the chore/add-meta-to-ts-types branch December 18, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client Core: Add meta to TS types for cubes and views

2 participants