Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Feb 13, 2024

…sion

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner February 13, 2024 00:45
@vercel
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 1:21am

@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (73b5c0d) 67.88% compared to head (9a32d95) 67.89%.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7751      +/-   ##
==========================================
+ Coverage   67.88%   67.89%   +0.01%     
==========================================
  Files         345      345              
  Lines       58009    58037      +28     
  Branches     5378     5239     -139     
==========================================
+ Hits        39379    39406      +27     
- Misses      17889    18437     +548     
+ Partials      741      194     -547     
Flag Coverage Δ
cube-backend 47.98% <ø> (ø)
cubesql 79.12% <96.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit b4b0f05 into master Feb 13, 2024
@paveltiunov paveltiunov deleted the ungrouped-aggregates branch February 13, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants