Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Feb 13, 2024

…re-aggregations

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested review from a team as code owners February 13, 2024 07:32
@vercel
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-react-d3 ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-react-dashboard ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-react-data-table ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-react-highcharts ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-react-pivot-table ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am
examples-vue-query-builder ⬜️ Ignored (Inspect) Feb 13, 2024 7:33am

@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (768325c) 79.12% compared to head (bb27698) 47.97%.

Files Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 50.00% 1 Missing and 1 partial ⚠️
packages/cubejs-api-gateway/src/gateway.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7752       +/-   ##
===========================================
- Coverage   79.12%   47.97%   -31.16%     
===========================================
  Files         191      154       -37     
  Lines       37120    20920    -16200     
  Branches        0     5240     +5240     
===========================================
- Hits        29373    10037    -19336     
- Misses       7747    10689     +2942     
- Partials        0      194      +194     
Flag Coverage Δ
cube-backend 47.97% <50.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 1a6451c into master Feb 13, 2024
@paveltiunov paveltiunov deleted the sql-push-down-disable-pre-aggs branch February 13, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants