feat(cubesql): Flatten IN lists expressions to improve performance #8235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after this changes next test fails: * test_inlist_expr * test_thoughtspot_where_binary_in_true_false they fails during `convert_select_to_query_plan` in `LanguageToLogicalPlanConverter::to_logical_plan`: `LogicalPlanLanguage::AllMembers` case `wrapped = false`
github-actions
bot
added
the
pr:community
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
fix works only when literals isn't null prev rule wasn't correct in case when `expr IN list` is FALSE
and test the case by SQL_PUSH_DOWN
Nikita-str
changed the title
IS (NOT) NULL rewrite rules
paveltiunov
approved these changes
May 13, 2024
paveltiunov
changed the title
paveltiunov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Partially addresses #6307