Skip to content

Conversation

@mcheshkov
Copy link
Contributor

This versions includes fix for MaterializeInc/rust-sasl#51, which includes unreleased patch for vendored version of cyrus-sasl

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Description of Changes Made (if issue reference is not provided)

At the moment sasl2-sys have version = "0.1.20+2.1.28" in Cargo.lock. This version contains vendored code of cyrus-sasl, that contains a bug (invalid autoconf header check), that leads to warning on older GCC, and that warning turns to error in GCC 14. It looks like this (and there's one more for clock):

[sasl2-sys 0.1.20+2.1.28] saslutil.c: In function 'sasl_mkchal':
[sasl2-sys 0.1.20+2.1.28] saslutil.c:280:3: error: implicit declaration of function 'time' [-Wimplicit-function-declaration]
[sasl2-sys 0.1.20+2.1.28]   280 |   time(&now);
[sasl2-sys 0.1.20+2.1.28]       |   ^~~~
[sasl2-sys 0.1.20+2.1.28] saslutil.c:66:1: note: 'time' is defined in header '<time.h>'; this is probably fixable by adding '#include <time.h>'
[sasl2-sys 0.1.20+2.1.28]    65 | #include "saslint.h"
[sasl2-sys 0.1.20+2.1.28]   +++ |+#include <time.h>
[sasl2-sys 0.1.20+2.1.28]    66 | #include <saslutil.h>

More on GCC change here, look for implicit-function-declaration
https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors
cyrus-sasl already fixed that in master, but haven't released new version yet:
cyrusimap/cyrus-sasl@266f0ac
sasl2-sys have backported that fix in as a patch to vendored version here:
MaterializeInc/rust-sasl@0186e52

I've basically ran cargo update sasl2-sys, that's it.

This versions includes fix for MaterializeInc/rust-sasl#51, which includes unreleased patch for vendored version of cyrus-sasl
@mcheshkov mcheshkov requested a review from a team as a code owner July 10, 2024 18:31
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jul 10, 2024
@KSDaemon
Copy link
Member

👍🏻

@mcheshkov mcheshkov merged commit c2f39ff into master Jul 10, 2024
@mcheshkov mcheshkov deleted the bump-sasl2-sys branch July 10, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants