Skip to content

Conversation

@mcheshkov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (8177daf) to head (06ae1ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/src/models/v1_cube_meta_dimension_granularity.rs 0.00% 10 Missing ⚠️
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8825   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         219      220    +1     
  Lines       78236    78260   +24     
=======================================
+ Hits        64737    64758   +21     
- Misses      13499    13502    +3     
Flag Coverage Δ
cubesql 82.74% <54.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 4:15pm

@mcheshkov mcheshkov marked this pull request as ready for review October 17, 2024 16:57
@mcheshkov mcheshkov requested a review from a team as a code owner October 17, 2024 16:57
@mcheshkov mcheshkov merged commit 9346f21 into master Oct 17, 2024
75 checks passed
@mcheshkov mcheshkov deleted the regen-cubeclient branch October 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants