-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(cubesql): Initial SQL pushdown flattening #8888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e51edfd to
7616fd8
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8888 +/- ##
==========================================
+ Coverage 82.55% 82.66% +0.11%
==========================================
Files 221 221
Lines 77734 78324 +590
==========================================
+ Hits 64174 64750 +576
- Misses 13560 13574 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…h_to_cube This name seems more appropriate, because actual WrappedSelect can represent grouped query when this field is set to true
7616fd8 to
b955b15
Compare
Some queries in tests reduced to a single CubeScan with member expressions, so tests have changed
b955b15 to
77e4461
Compare
Check List
Description of Changes Made (if issue reference is not provided)
Flatten
Aggregation(Filter(CubeScan))to a singleCubeScanWrapper(push_to_cube=true)