Skip to content

Conversation

@johancube
Copy link
Contributor

@johancube johancube commented Nov 4, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This solution ensures that all related packages work together seamlessly without concern for missing links.

@johancube johancube requested a review from KSDaemon November 4, 2024 19:15
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 4, 2024
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Great improvement and simplification! But I think there are some things to be resolved. Left comments inline.

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:03am

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Seems to be good! Let's try it :)

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Awesome!

@KSDaemon KSDaemon merged commit ae823c9 into master Nov 25, 2024
32 of 33 checks passed
@KSDaemon KSDaemon deleted the fix/dev-env-setup branch November 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants