feat(cubesql): Penalize zero members in wrapper

packages/cubejs-schema-compiler/src/adapter/BaseTimeDimension.ts

@@ -70,10 +70,14 @@ export class BaseTimeDimension extends BaseFilter {
     return super.aliasName();
   }
 
-  // @ts-ignore
-  public unescapedAliasName(granularity: string) {
+  public unescapedAliasName(granularity?: string) {
     const actualGranularity = granularity || this.granularityObj?.granularity || 'day';
 
+    const fullName = `${this.dimension}.${actualGranularity}`;
+    if (this.query.options.memberToAlias && this.query.options.memberToAlias[fullName]) {
+      return this.query.options.memberToAlias[fullName];
+    }
+
     return `${this.query.aliasName(this.dimension)}_${actualGranularity}`; // TODO date here for rollups
   }
 

packages/cubejs-testing/test/__snapshots__/smoke-cubesql.test.ts.snap

@@ -232,6 +232,84 @@ Array [
 ]
 `;
 
+exports[`SQL API Postgres (Data) select __user and literal grouped under wrapper: select __user and literal in wrapper 1`] = `
+Array [
+  Object {
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "new",
+    "my_user": null,
+  },
+  Object {
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "processed",
+    "my_user": null,
+  },
+  Object {
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "shipped",
+    "my_user": null,
+  },
+]
+`;
+
+exports[`SQL API Postgres (Data) select __user and literal grouped: select __user and literal 1`] = `
+Array [
+  Object {
+    "Int64(2)": "2",
+    "__cubeJoinField": null,
+    "datetrunc(Utf8(\\"day\\"),Orders.createdAt)": 2024-01-01T00:00:00.000Z,
+    "id": 1,
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "new",
+    "my_user": null,
+  },
+  Object {
+    "Int64(2)": "2",
+    "__cubeJoinField": null,
+    "datetrunc(Utf8(\\"day\\"),Orders.createdAt)": 2024-01-02T00:00:00.000Z,
+    "id": 2,
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "new",
+    "my_user": null,
+  },
+  Object {
+    "Int64(2)": "2",
+    "__cubeJoinField": null,
+    "datetrunc(Utf8(\\"day\\"),Orders.createdAt)": 2024-01-03T00:00:00.000Z,
+    "id": 3,
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "processed",
+    "my_user": null,
+  },
+  Object {
+    "Int64(2)": "2",
+    "__cubeJoinField": null,
+    "datetrunc(Utf8(\\"day\\"),Orders.createdAt)": 2024-01-04T00:00:00.000Z,
+    "id": 4,
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "processed",
+    "my_user": null,
+  },
+  Object {
+    "Int64(2)": "2",
+    "__cubeJoinField": null,
+    "datetrunc(Utf8(\\"day\\"),Orders.createdAt)": 2024-01-05T00:00:00.000Z,
+    "id": 5,
+    "my_created_at": 2024-01-01T00:00:00.000Z,
+    "my_literal": "1",
+    "my_status": "shipped",
+    "my_user": null,
+  },
+]
+`;
+
 exports[`SQL API Postgres (Data) select null in subquery with streaming 1`] = `
 Array [
   Object {

packages/cubejs-testing/test/smoke-cubesql.test.ts

@@ -404,6 +404,78 @@ describe('SQL API', () => {
       expect(res.rows).toEqual([{ max: null }]);
     });
 
+    test('select __user and literal grouped', async () => {
+      const query = `
+        SELECT
+          status AS my_status,
+          date_trunc('month', createdAt) AS my_created_at,
+          __user AS my_user,
+          1 AS my_literal,
+          -- Columns without aliases should also work
+          id,
+          date_trunc('day', createdAt),
+          __cubeJoinField,
+          2
+        FROM
+          Orders
+        GROUP BY 1,2,3,4,5,6,7,8
+        ORDER BY 1,2,3,4,5,6,7,8
+      `;
+
+      const res = await connection.query(query);
+      expect(res.rows).toMatchSnapshot('select __user and literal');
+    });
+
+    test('select __user and literal grouped under wrapper', async () => {
+      const query = `
+        WITH
+-- This subquery should be represented as CubeScan(ungrouped=false) inside CubeScanWrapper
+cube_scan_subq AS (
+  SELECT
+    status AS my_status,
+    date_trunc('month', createdAt) AS my_created_at,
+    __user AS my_user,
+    1 AS my_literal,
+    -- Columns without aliases should also work
+    id,
+    date_trunc('day', createdAt),
+    __cubeJoinField,
+    2
+  FROM Orders
+  GROUP BY 1,2,3,4,5,6,7,8
+),
+filter_subq AS (
+  SELECT
+    status status_filter
+  FROM Orders
+  GROUP BY
+    status_filter
+)
+        SELECT
+          -- Should use SELECT * here to reference columns without aliases.
+          -- But it's broken ATM in DF, initial plan contains \`Projection: ... #__subquery-0.logs_content_filter\` on top, but it should not be there
+          -- TODO fix it
+          my_created_at,
+          my_status,
+          my_user,
+          my_literal
+        FROM cube_scan_subq
+        WHERE
+          -- This subquery filter should trigger wrapping of whole query
+          my_status IN (
+            SELECT
+              status_filter
+            FROM filter_subq
+          )
+        GROUP BY 1,2,3,4
+        ORDER BY 1,2,3,4
+        ;
+        `;
+
+      const res = await connection.query(query);
+      expect(res.rows).toMatchSnapshot('select __user and literal in wrapper');
+    });
+
     test('where segment is false', async () => {
       const query =
         'SELECT value AS val, * FROM "SegmentTest" WHERE segment_eq_1 IS FALSE ORDER BY value;';