Skip to content

chore(cubestore): Remove dependency on feature(cursor_remaining) in c… #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore(cubestore): Remove dependency on feature(cursor_remaining) in c… #8964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d33aa73
chore(cubestore): Remove dependency on feature(cursor_remaining) in c…
srh Nov 17, 2024
44701dd
chore(cubestore): Typo in README
srh Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/cubestore/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ exclude this from your PR!)
```

[patch.'https://github.com/cube-js/arrow-rs']
arquet = { path = "../../../arrow-rs/parquet" }
parquet = { path = "../../../arrow-rs/parquet" }
arrow = { path = "../../../arrow-rs/arrow" }

[patch.'https://github.com/cube-js/arrow-datafusion']
Expand Down
2 changes: 1 addition & 1 deletion rust/cubestore/cubehll/src/instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl HllInstance {
let mut values = Vec::with_capacity(num_hashes);
let mut data = Cursor::new(data);
let maxval = (1 << reg_width) as u32 - 1;
while !data.is_empty() {
while data.position() < data.get_ref().len() as u64 {
let hash = data.read_u64::<BigEndian>().unwrap();
let ind = hash & mask;
let val = hash >> log_num_buckets;
Expand Down
1 change: 0 additions & 1 deletion rust/cubestore/cubehll/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![feature(cursor_remaining)]
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Loading