Skip to content

Conversation

@bsod90
Copy link
Member

@bsod90 bsod90 commented Nov 26, 2024

Previous logic was incorrectly excluding members if any of the applicable policies exclude it. The right approach is to allow a member if any of the applicable policies allows it

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Previous logic was incorrectly excluding members if any of the
applicable policies exclude it. The right approach is to allow
a member if any of the applicable policies allows it
@bsod90 bsod90 requested a review from a team as a code owner November 26, 2024 02:57
@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-react-d3 ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-react-dashboard ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-react-data-table ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-react-highcharts ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-react-pivot-table ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am
examples-vue-query-builder ⬜️ Ignored (Inspect) Nov 26, 2024 2:57am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 26, 2024
@bsod90 bsod90 requested a review from paveltiunov November 26, 2024 02:57
@bsod90 bsod90 merged commit ff89d65 into master Nov 26, 2024
57 of 59 checks passed
@bsod90 bsod90 deleted the fix_member_policy_evaluation branch November 26, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants