Skip to content

Conversation

@benyaminsalimi
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

feat(duckdb-driver): Add support for installing and loading DuckDB Community Extensions

@benyaminsalimi benyaminsalimi requested review from a team as code owners February 1, 2025 09:09
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Feb 1, 2025
@igorlukanin
Copy link
Member

@benyaminsalimi Could you please explain what's the difference between official and community extensions? Why do we need to handle the community ones differently?

@benyaminsalimi
Copy link
Contributor Author

benyaminsalimi commented Feb 13, 2025

@benyaminsalimi Could you please explain what's the difference between official and community extensions? Why do we need to handle the community ones differently?

@igorlukanin The community extension is from another repository (community), example of installing community extension INSTALL quack FROM community; you can see the FROM community added to the statement.

You can find more information here

I was also thinking about add feature of install from 3rd party repositories, which Duck DB supports! It will be FROM "repo URL" ( in another PR)

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Looks good! Left only one neat pick rgd types

@KSDaemon
Copy link
Member

KSDaemon commented Mar 7, 2025

@benyaminsalimi, could you please sync with the latest master and resolve the conflicts (should not be hard)? Thnx!

@KSDaemon KSDaemon self-assigned this Mar 7, 2025
…ty-extensions

# Conflicts:
#	packages/cubejs-duckdb-driver/src/DuckDBDriver.ts
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.02%. Comparing base (e7901a7) to head (db6ae2e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/env.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9169      +/-   ##
==========================================
- Coverage   48.03%   48.02%   -0.02%     
==========================================
  Files         171      171              
  Lines       21449    21454       +5     
  Branches     3723     3724       +1     
==========================================
  Hits        10303    10303              
- Misses      10714    10719       +5     
  Partials      432      432              
Flag Coverage Δ
cube-backend 48.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon merged commit c97f99a into cube-js:master Apr 14, 2025
52 checks passed
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…mmunity Extensions (cube-js#9169)

* feat(duckdb-driver): Add support for installing and loading DuckDB Community Extensions

* remarks on PR

---------

Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants