Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR updates open spec and generated files, adding hierarchies to meta in cubeclient, exposing them to cubesql and dependencies.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested review from a team as code owners February 4, 2025 15:58
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.34%. Comparing base (4c8de88) to head (98c2fca).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ql/cubeclient/src/models/v1_cube_meta_hierarchy.rs 0.00% 7 Missing ⚠️
rust/cubesql/cubeclient/src/models/v1_cube_meta.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9180      +/-   ##
==========================================
- Coverage   83.35%   83.34%   -0.01%     
==========================================
  Files         226      227       +1     
  Lines       81045    81062      +17     
==========================================
+ Hits        67552    67561       +9     
- Misses      13493    13501       +8     
Flag Coverage Δ
cubesql 83.34% <52.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 56dbf9e into master Feb 4, 2025
70 checks passed
@MazterQyou MazterQyou deleted the cubeclient/hierarchies-meta branch February 4, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants