fix(query-orchestrator): Fix dropping temp tables during pre-agg creation #9295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
approved these changes
Mar 5, 2025
KSDaemon
force-pushed
the
fix/temp-table-drop-lock
branch
from
816d458 to
04eaedd
Compare
ovr
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes improper temp table removal during pre-aggregation creations.
The same CacheLock Key was used for dropping tables, so in the case when there were more than 1 simultaneous
temp table creations (e.g. a few partitions for the table) - there was lock contention which prevents table drops.
Check List