chore(schema-compiler)!: Drop support for top-level includes/excludes in views #9401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
approved these changes
Mar 31, 2025
KSDaemon
force-pushed
the
depr/remove-view-includes
branch
from
56893df to
16aac27
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9401 +/- ##
==========================================
- Coverage 47.90% 47.89% -0.02%
==========================================
Files 171 171
Lines 21425 21411 -14
Branches 3713 3707 -6
==========================================
- Hits 10264 10254 -10
+ Misses 10728 10725 -3
+ Partials 433 432 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
force-pushed
the
depr/remove-view-includes
branch
from
16aac27 to
797b914
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
… in views (cube-js#9401) * chore(schema-compiler)!: Drop support for top-level includes/excludes in views * fix view tests * Update DEPRECATION --------- Co-authored-by: Igor Lukanin <igor@cube.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for top-level includes/excludes in views, which were deprecated long ago...
Check List