Revert "fix(schema-compiler): Use join paths from pre-aggregation declaration instead of building join tree from scratch (#9431)" #9448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
approved these changes
Apr 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9448 +/- ##
==========================================
- Coverage 47.97% 47.91% -0.07%
==========================================
Files 171 171
Lines 21424 21387 -37
Branches 3710 3707 -3
==========================================
- Hits 10279 10248 -31
+ Misses 10706 10702 -4
+ Partials 439 437 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…laration instead of building join tree from scratch (cube-js#9431)" (cube-js#9448) This reverts commit aea3a6c, PR cube-js#9431 It contains a bug in pre-aggregation matching, rendering any pre-agg with join path unusable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes Made (if issue reference is not provided)
This reverts commit aea3a6c, PR #9431
It contains a bug in pre-aggregation matching, rendering any pre-agg with join path unusable