Fix attachment rendering #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Cucumber JVM attachments can be created in a few different ways. How influences whether the attachment ends up as elements of `embeddings` or `output`. | Method | Encoding | Media Type | Destination | | ------------------------------ | -------- | ------------------------- | ------------ | | `Scenario.attach(byte[], ...)` | BASE64 | any, from method | `embeddings` | | `Scenario.attach(String, ...)` | IDENTITY | any, from method | `embeddings` | | `Scenario.log(String)` | IDENTITY | text/x.cucumber.log+plain | `output` | Originally the implementation determined the destination based on the encoding, but this is obviously not correct. An alternative would be to select on the media type. This does come with the disadvantage that `Scenario.attach` also takes in a media type argument. So in theory that could be `text/x.cucumber.log+plain` but for now we'll assume that is not the case. Should this assumption prove wrong we could match on both encoding and media type, but it would be more reasonable for the user to change their code. Fixes: cucumber/cucumber-jvm#3069
mpkorstanje
force-pushed
the
fix-attachment-rendering
branch
from
30c344c to
b1eec04
Compare
mpkorstanje
added a commit
that referenced
this pull request
Sep 9, 2025
While the compatibility already contains samples with attachments it is also useful to have these in the regression set against Cucumber-JVM 7.26 should there be other attachment related bugs in the future. This complements #12.
mpkorstanje
added a commit
that referenced
this pull request
Sep 9, 2025
While the compatibility already contains samples with attachments it is also useful to have these in the regression set against Cucumber-JVM 7.26 should there be other attachment related bugs in the future. This complements #12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
In Cucumber JVM attachments can be created in a few different ways. How influences whether the attachment ends up as elements of
embeddingsoroutput.Scenario.attach(byte[], ...)embeddingsScenario.attach(String, ...)embeddingsScenario.log(String)outputOriginally the implementation determined the destination based on the encoding, but this is obviously not correct. An alternative would be to select on the media type.
This does come with the disadvantage that
Scenario.attachalso takes in a media type argument. So in theory that could betext/x.cucumber.log+plainbut for now we'll assume that is not the case.Should this assumption prove wrong we could match on both encoding and media type, but it would be more reasonable for the user to change their code.
Fixes: cucumber/cucumber-jvm#3069
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
If you are using
text/x.cucumber.log+plainin combination withScenario.attachplease let us know your use case.📋 Checklist: