Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Sep 15, 2018

Summary

This PR suppresses the following warnings.

% bundle install
The git source `git://github.com/cucumber/cucumber-ruby-core.git` uses
the `git` protocol, which transmits data without encryption. Disable
this warning with `bundle config git.allow_insecure true`, or switch to
the `https` protocol to keep your data secure.
The git source `git://github.com/cucumber/cucumber-ruby-wire.git` uses
the `git` protocol, which transmits data without encryption. Disable
this warning with `bundle config git.allow_insecure true`, or switch to
the `https` protocol to keep your data secure.
Fetching git://github.com/cucumber/cucumber-ruby-core.git
Fetching git://github.com/cucumber/cucumber-ruby-wire.Git

Refer: rubygems/bundler#4127

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This PR suppresses the following warnings.

```console
% bundle install
The git source `git://github.com/cucumber/cucumber-ruby-core.git` uses
the `git` protocol, which transmits data without encryption. Disable
this warning with `bundle config git.allow_insecure true`, or switch to
the `https` protocol to keep your data secure.
The git source `git://github.com/cucumber/cucumber-ruby-wire.git` uses
the `git` protocol, which transmits data without encryption. Disable
this warning with `bundle config git.allow_insecure true`, or switch to
the `https` protocol to keep your data secure.
Fetching git://github.com/cucumber/cucumber-ruby-core.git
Fetching git://github.com/cucumber/cucumber-ruby-wire.Git
```

Refer: rubygems/bundler#4127
@ghost ghost assigned koic Sep 15, 2018
@koic
Copy link
Member Author

koic commented Sep 15, 2018

CI has failed, but I think that this change is irrelevant.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to avoid warnings!

@koic koic merged commit d23f12d into cucumber:master Sep 16, 2018
@koic koic deleted the use_secure_protocol_when_running_bundle_install branch September 16, 2018 18:51
@koic
Copy link
Member Author

koic commented Sep 16, 2018

@olleolleolle Thanks for your approval.

@lock
Copy link

lock bot commented Sep 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants