Skip to content

Conversation

@davidjgoss
Copy link
Contributor

🤔 What's changed?

  • Use latest React components including with new package name
  • Update documentation accordingly
  • Add a readme to the javascript package that explains to users that it's internal (I have seen a few users in the wild installing it themselves)

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Feat/react 20 0 0 use react-components 20.0.0, update docs Apr 12, 2022
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Just have to fix the CI

Also, could be nice to have the same notice in READMEs for ruby and java implementations

@davidjgoss davidjgoss marked this pull request as draft April 14, 2022 09:48
@davidjgoss davidjgoss marked this pull request as ready for review April 14, 2022 15:30
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidjgoss davidjgoss merged commit 39a5e1a into main Apr 15, 2022
@davidjgoss davidjgoss deleted the feat/react-20-0-0 branch April 15, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants