Skip to content

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 16, 2025

🤔 What's changed?

The method variant findTestStepsStartedBy(TestCaseFinished) has no test coverage in Java and didn't exist in JavaScript. This PR remedies both of these by extending the acceptance test and then updating the JavaScript implementation so it passes.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I'm not quite sure I've followed the pattern right with the acceptance tests - @mpkorstanje?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review September 16, 2025 15:54
@davidjgoss davidjgoss merged commit f99b49b into main Sep 16, 2025
8 checks passed
@davidjgoss davidjgoss deleted the findTestStepsStartedBy-fix branch September 16, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant