-
Notifications
You must be signed in to change notification settings - Fork 12
Hide successful hooks by default #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The ideal solution would be to show only hooks that are not (passed, skipped). And the first hook that is skipped, and preceeded by a passing hook or step. |
Or indeed is not preceded by any step (skip on first hook). That should be doable. |
# Conflicts: # src/components/gherkin/GherkinDocument.stories.tsx
mpkorstanje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick aside.
|
Btw, I really like the new section in the preview with all the CKK examples! |
🤔 What's changed?
By default, omit hook steps when rendering a test case outcome unless the hook has a non-success status. Also, provide a button to reveal them.
Screen.Recording.2025-11-15.at.11.48.17.mov
⚡️ What's your motivation?
Fixes #414.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
This implementation shows any non-successful hooks by default. That would include skipped hooks. Do we want that, or should be just show failed hooks by default? There are conflicting use cases here:
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.