-
-
Notifications
You must be signed in to change notification settings - Fork 91
Description
In the following:
aaa_bbb_ccc_ddd_eee
If you say "chuck second until fourth word"
, you get
aaa_eee
Instead of
aaa_ddd_eee
The problem is that we take the trailing delimiter from the active target in the range even if we're excluding it:
cursorless/packages/cursorless-engine/src/processTargets/targets/SubTokenWordTarget.ts
Line 66 in 3fe5d81
trailingDelimiterRange: endTarget.trailingDelimiterRange_, |
We should really downgrade the target to an untyped target if either end is excluded,
because it no longer can be viewed as a range of the given type. For example "token air until bat"
in aaa bbb
, is not really a token range, because it is aaa
.
I think we probably should stop leaving so much of createContinuousRangeTarget
to be determined by the derived class. We should try to solve the circular dep while we're there.