Skip to content

Exclusive ranges get wrong trailing delimiter for word targets #2068

@pokey

Description

@pokey

In the following:

aaa_bbb_ccc_ddd_eee

If you say "chuck second until fourth word", you get

aaa_eee

Instead of

aaa_ddd_eee

The problem is that we take the trailing delimiter from the active target in the range even if we're excluding it:

trailingDelimiterRange: endTarget.trailingDelimiterRange_,

We should really downgrade the target to an untyped target if either end is excluded,
because it no longer can be viewed as a range of the given type. For example "token air until bat" in aaa bbb, is not really a token range, because it is aaa .

I think we probably should stop leaving so much of createContinuousRangeTarget to be determined by the derived class. We should try to solve the circular dep while we're there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions