Add action to add a type annotation

[alexhwoods]

What we want

We will make it so that the "clear" / "change" action, when applied to "type", if there is no existing type annotation, will insert a : and leave the cursor afterwords so that the user can add a type.

For example:

function foo() {
  return "hello" // cursor at end of this line
}

User says “change type”, results in

function foo(): <cursor-here> {
  return "hello"
}

Implementation

We will leverage #210 to make it so that target returned from "type" knows how to insert itself

[pokey]

cc/ @AndreasArvidsson @soheeyang @sterlind

[AndreasArvidsson]

I'm unsure if I like the idea of clear actually adding text.

[pokey]

I have slightly mixed feelings as well. But the capability described here seems useful. Any ideas for alternative ways to express this command?

[AndreasArvidsson]

I agree that it's useful and I have had a need for something similar.

[soheeyang]

I'm sorry for the late catch-up! I also think that the command would be useful, but using clear for this function might not be an optimal solution.

[pokey]

So do we add a new "add" action then? "Set"?

[soheeyang]

Would there be more cases to add something other than type? (Would the action be more generalized?)
Also, for the languages that do not have the type annotation, would the command be deactivated?

[AndreasArvidsson]

When the action is called change it makes perfect sense. As a clear command I'm a bit ambivalent. Also adding a new action for this very niche case is probably unnecessary.

[soheeyang]

My opinion is the same as Andreas's.

[pokey]

But the action is called "change" today

[AndreasArvidsson]

The default spoken form is. The action is called clearAndSetSelection

[pokey]

Yes maybe we were a bit too explicit there 😅

[AndreasArvidsson]

Yes if the action is going to be change on even add the action name is definitely incorrect