Skip to content

Support as const for "type" #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Support as const for "type" #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...es/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/typescript/changeType9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
languageId: typescript
command:
version: 6
spokenForm: change type
action:
name: clearAndSetSelection
target:
type: primitive
modifiers:
- type: containingScope
scopeType: {type: type}
usePrePhraseSnapshot: true
initialState:
documentContents: const aaa = "bbb" as const;
selections:
- anchor: {line: 0, character: 12}
active: {line: 0, character: 12}
marks: {}
finalState:
documentContents: const aaa = "bbb" as ;
selections:
- anchor: {line: 0, character: 21}
active: {line: 0, character: 21}
23 changes: 23 additions & 0 deletions ...ges/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/typescript/chuckType5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
languageId: typescript
command:
version: 6
spokenForm: chuck type
action:
name: remove
target:
type: primitive
modifiers:
- type: containingScope
scopeType: {type: type}
usePrePhraseSnapshot: true
initialState:
documentContents: const aaa = "bbb" as const;
selections:
- anchor: {line: 0, character: 12}
active: {line: 0, character: 12}
marks: {}
finalState:
documentContents: const aaa = "bbb";
selections:
- anchor: {line: 0, character: 12}
active: {line: 0, character: 12}
5 changes: 1 addition & 4 deletions queries/typescript.core.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,7 @@
;;! ----------
(as_expression
(_) @_.leading.start.endOf
[
(generic_type)
(predefined_type)
] @type @_.leading.end.startOf
(_) @type @_.leading.end.startOf
) @_.domain

;;!! aaa satisfies Bbb
Expand Down