Skip to content

Update typescript scopes #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2023
Merged

Update typescript scopes #2085

merged 2 commits into from
Dec 5, 2023

Conversation

@AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 5, 2023 •
edited
Loading

Fixes #2072
Fixes #2083
Fixes #2033

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson changed the title Fix public fields Update typescript scopes Dec 5, 2023
pokey
pokey approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pokey pokey added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 990c98b Dec 5, 2023
@pokey pokey deleted the typescript_scopes branch December 5, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pokey pokey pokey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"value" broken for fields in classes typescript: "type" broken for methods and fields "type" scope doesn't work when you're after the semicolon

3 participants

@AndreasArvidsson @pokey