Skip to content

Added python import to collection item #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Added python import to collection item #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cursorless-engine/src/languages/python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ const nodeMatchers: Partial<
itemNodeFinder("import_from_statement", "dotted_name", true),
argumentSelectionExtractor(),
),
matcher(
itemNodeFinder("import_statement", "dotted_name", false),
argumentSelectionExtractor(),
),
matcher(
itemNodeFinder("global_statement", "identifier"),
argumentSelectionExtractor(),
Expand Down
23 changes: 23 additions & 0 deletions packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/python/chuckItem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
languageId: python
command:
version: 6
spokenForm: chuck item
action:
name: remove
target:
type: primitive
modifiers:
- type: containingScope
scopeType: {type: collectionItem}
usePrePhraseSnapshot: true
initialState:
documentContents: import foo, baz
selections:
- anchor: {line: 0, character: 7}
active: {line: 0, character: 7}
marks: {}
finalState:
documentContents: import baz
selections:
- anchor: {line: 0, character: 7}
active: {line: 0, character: 7}