Add GDScript to supported languages #3092
Conversation
…, that's the point actually, it's a work in progress!!!
…, that's the point actually, it's a work in progress!!!
…nto gdscript-support
|
You need to run prettier. That is what pre commit is complaining about. |
There was a problem hiding this comment.
Not a big fan of committing an empty file. Please add at least one scope to it. You can do something simple like comment for example.
There was a problem hiding this comment.
Going to need to make another PR to add another codium cli naming related fix first so I can more easily do that, but once that's done that should be easy enough
There was a problem hiding this comment.
See #3093 for the fixes mentioned above
There was a problem hiding this comment.
I don't follow why you would need to update the scripts first? Personally I don't use those scripts at all.
You just run the Cursorless extension from inside of vscode/codium when developing.
There was a problem hiding this comment.
It's required in this very specific instance because gdscript isn't supported by prod yet, and I can't get developing from the cursorlessDevelopment dev profile to work for some reason. Probably need to delete and remake the thing?
I can probably bootstrap a local version using the scripts update I made by building from this PR, at the very least, so getting that PR in isn't urgent for now
There was a problem hiding this comment.
I would definitely recommend getting the development profile working. That will hot reload and apply any changes whenever you save a scm file.
Removing the profile/sandbox and installing it again sounds like something to try.
2 participants
Doesn't actually implement any scopes (though it does define a few as being
notApplicable), but defines gdscript (.gd) as a supported language, easing further development by not requiring me to run a local build of Cursorless when working on actual scope implementations in the future. This has been done for quite a while but I've not had the time to submit the PR until now due to a generally stressful fall semester and catching COVID during the first week of classes, so I thought I'd get the PR in now before I forget again >.<