Skip to content

Separate VSCode publish jobs #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −4
Open

Separate VSCode publish jobs #3106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [main]

jobs:
publish-extension:
publish-to-open-vsx:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
environment: production
Expand Down Expand Up @@ -47,14 +47,37 @@ jobs:
with:
pat: ${{ secrets.OPEN_VSX_TOKEN }}
packagePath: packages/cursorless-vscode/dist
skipDuplicate: true

- name: Upload VSIX
uses: actions/upload-artifact@v4
with:
name: vscode-extension
path: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
retention-days: 1
Copy link
Member

@AndreasArvidsson AndreasArvidsson Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need overwrite: true? Advise I think it will fail if we do to deployments in the same day.


publish-to-vs-marketplace:
runs-on: ubuntu-latest
needs: publish-to-open-vsx
environment: production

steps:
- name: Download VSIX
uses: actions/download-artifact@v4
with:
name: vscode-extension

- name: Get VSIX file path
id: getPath
run: |
VSIX_FILE=$(find . -maxdepth 1 -name "*.vsix" -type f)
echo "vsixPath=$VSIX_FILE" >> $GITHUB_OUTPUT

- name: Publish to Visual Studio Marketplace
uses: HaaLeo/publish-vscode-extension@v2
with:
pat: ${{ secrets.VS_MARKETPLACE_TOKEN }}
registryUrl: https://marketplace.visualstudio.com
extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
extensionFile: ${{ steps.getPath.outputs.vsixPath }}

publish-neovim-extension:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -116,7 +139,7 @@ jobs:
push-cursorless-talon:
name: Push cursorless-talon subrepo
runs-on: ubuntu-latest
needs: publish-extension
needs: [publish-to-vs-marketplace, publish-neovim-extension]
Copy link
Member

@AndreasArvidsson AndreasArvidsson Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut feeling is that if we successfully update the vscode marketplace we should also update the Talon repository regardless of neovim status. Historically the neovim publishing have been a bit flaky.

Copy link
Member

@pokey pokey Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

environment: production

steps:
Expand Down
Loading