Pattern matching support #831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you symlinked / copied cursorless-talon subdir of this branch into your talon user directory, replacing the deployed version of cursorless? If so, maybe try restarting talon and saying "cursorless help" to see if they're appearing in the cheatsheet? |
purpleP
force-pushed
the
feature/pattern_matching
branch
from
b268a18 to
3950011
Compare
Thanks, that helped! Tell me please what do I need to add so that |
|
What should we do with alternatives in patterns in Rust? Python also has them. I would propose to use new |
purpleP
force-pushed
the
feature/pattern_matching
branch
from
99d9110 to
0e562f4
Compare
purpleP
force-pushed
the
feature/pattern_matching
branch
from
3370e89 to
e533feb
Compare
purpleP
force-pushed
the
feature/pattern_matching
branch
from
e533feb to
3a3fdc6
Compare
purpleP
force-pushed
the
feature/pattern_matching
branch
from
abbf158 to
55ebccb
Compare
purpleP
force-pushed
the
feature/pattern_matching
branch
from
55ebccb to
7e7fcc4
Compare
3 tasks
This was referenced Nov 18, 2022
AndreasArvidsson
added a commit
that referenced
this pull request
Dec 15, 2022
- Partially addresses #1172 - Waiting to add Talon side until we're more confident in this scope type - Split from #831 ## Checklist - [x] Add Typescript - [x] Add C - [x] Add C# - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet Co-authored-by: Michael Doronin <warrior2031@mail.ru> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
pokey
added a commit
that referenced
this pull request
Dec 21, 2022
- Partially addresses #1172 - Waiting to add Talon side until we're more confident in this scope type - Split from #831 ## Checklist - [x] Add Typescript - [x] Add C - [x] Add C# - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet Co-authored-by: Michael Doronin <warrior2031@mail.ru> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
pokey
added a commit
that referenced
this pull request
Dec 22, 2022
- Adds `condition` support for Python ternaries - Adds `condition` support for Python list comprehensions - Adds `condition` support for Python match statements - Adds `condition` support for Rust match statements - Note that `"chuck"` includes the `if` keyword for match statements and list comprehensions - Split from #831 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet Co-authored-by: Michael Doronin <warrior2031@mail.ru> Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m working on pattern matching support as discussed here and planning to add it to rust, java, c, c++, python, javascript, typescript and haskell (languages I know).
So far I don’t think cursorless even recognised new scopes. @pokey Can you point what I’m missing here?