chore: return proper promises

.github/workflows/ci.yaml

@@ -59,6 +59,14 @@ jobs:
           ELECTRON_ENABLE_LOGGING: true # send console logs to stdout in electron browser
           NODE_ENV: test
 
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: cypress-component-${{ matrix.browser }}-${{ matrix.count }}
+          path: tests/cypress/screenshots
+          retention-days: 1
+          if-no-files-found: error
+
   cypress-component-rpc:
     name: Cypress component tests with RPC
     if: github.ref_name == 'main'
@@ -88,6 +96,8 @@ jobs:
         with:
           name: cypress-rpc
           path: tests/cypress/screenshots
+          retention-days: 1
+          if-no-files-found: error
 
   cypress-e2e:
     strategy:
@@ -98,7 +108,7 @@ jobs:
         include:
           - browser: chrome
             count: 2
-    name: Cypress in ${{ matrix.browser }} ${{ matrix.count }}
+    name: Cypress e2e tests in ${{ matrix.browser }} ${{ matrix.count }}
     timeout-minutes: 15
     runs-on: ubuntu-latest
     steps:
@@ -134,7 +144,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: cypress-main-${{ matrix.browser }}-${{ matrix.count }}
+          name: cypress-e2e-${{ matrix.browser }}-${{ matrix.count }}
           path: tests/cypress/screenshots
           retention-days: 1
           if-no-files-found: error

apps/main/src/dao/components/Charts/GaugeWeightHistoryChart/index.tsx

@@ -5,6 +5,7 @@ import ErrorMessage from '@/dao/components/ErrorMessage'
 import useStore from '@/dao/store/useStore'
 import Spinner, { SpinnerWrapper } from '@ui/Spinner'
 import { t } from '@ui-kit/lib/i18n'
+import { errorFallback } from '@ui-kit/utils/error.util'
 
 interface GaugeWeightHistoryChartProps {
   gaugeAddress: string
@@ -21,7 +22,7 @@ const GaugeWeightHistoryChart = ({ gaugeAddress, minHeight }: GaugeWeightHistory
 
   useEffect(() => {
     if (!gaugeWeightHistoryMapper[gaugeAddress]) {
-      void getHistoricGaugeWeights(gaugeAddress)
+      getHistoricGaugeWeights(gaugeAddress).catch(errorFallback)
     }
   }, [gaugeAddress, gaugeWeightHistoryMapper, getHistoricGaugeWeights])
 
@@ -33,7 +34,7 @@ const GaugeWeightHistoryChart = ({ gaugeAddress, minHeight }: GaugeWeightHistory
             message={t`Error fetching historical gauge weights data`}
             onClick={(e?: MouseEvent) => {
               e?.stopPropagation()
-              void getHistoricGaugeWeights(gaugeAddress)
+              getHistoricGaugeWeights(gaugeAddress).catch(errorFallback)
             }}
           />
         </ErrorWrapper>

apps/main/src/dao/components/PageAnalytics/DailyLocksChart/index.tsx

@@ -4,6 +4,7 @@ import ErrorMessage from '@/dao/components/ErrorMessage'
 import useStore from '@/dao/store/useStore'
 import Box from '@ui/Box'
 import { t } from '@ui-kit/lib/i18n'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import Spinner from '../../Spinner'
 import PositiveAndNegativeBarChart from './PositiveAndNegativeBarChart'
 
@@ -17,7 +18,7 @@ const DailyLocks = () => {
 
   useEffect(() => {
     if (veCrvLocks.locks.length === 0 && veCrvLocks.fetchStatus !== 'ERROR') {
-      void getVeCrvLocks()
+      getVeCrvLocks().catch(errorFallback)
     }
   }, [getVeCrvLocks, veCrvLocks.locks.length, veCrvLocks.fetchStatus])
 

apps/main/src/dao/components/PageAnalytics/VeCrvFeesTable/index.tsx

@@ -5,6 +5,7 @@ import useStore from '@/dao/store/useStore'
 import Box from '@ui/Box'
 import { formatDate, formatNumber } from '@ui/utils'
 import { t } from '@ui-kit/lib/i18n'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import Spinner from '../../Spinner'
 import VeCrvFeesChart from '../VeCrvFeesChart'
 
@@ -18,7 +19,7 @@ const VeCrcFees = () => {
 
   useEffect(() => {
     if (veCrvFees.fees.length === 0 && !feesError) {
-      void getVeCrvFees()
+      getVeCrvFees().catch(errorFallback)
     }
   }, [getVeCrvFees, veCrvFees, feesError])
 

apps/main/src/dao/components/PageAnalytics/index.tsx

@@ -4,6 +4,7 @@ import useStore from '@/dao/store/useStore'
 import Box from '@ui/Box'
 import { t } from '@ui-kit/lib/i18n'
 import { TabsSwitcher, type TabOption } from '@ui-kit/shared/ui/TabsSwitcher'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import CrvStats from './CrvStats'
 import DailyLocks from './DailyLocksChart'
 import HoldersTable from './HoldersTable'
@@ -24,7 +25,7 @@ const Analytics = () => {
 
   useEffect(() => {
     if (veCrvHolders.topHolders.length === 0 && veCrvHolders.fetchStatus !== 'ERROR') {
-      void getVeCrvHolders()
+      getVeCrvHolders().catch(errorFallback)
     }
   }, [getVeCrvHolders, veCrvHolders.topHolders.length, veCrvHolders.fetchStatus])
 

apps/main/src/dao/components/PageGauge/GaugeVotesTable/index.tsx

@@ -9,6 +9,7 @@ import { formatLocaleDate } from '@ui/utils/'
 import { t } from '@ui-kit/lib/i18n'
 import { DAO_ROUTES } from '@ui-kit/shared/routes'
 import { shortenAddress } from '@ui-kit/utils'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import { GAUGE_VOTES_TABLE_LABELS } from './constants'
 
 interface GaugeVotesTableProps {
@@ -40,7 +41,7 @@ const GaugeVotesTable = ({ gaugeAddress, tableMinWidth }: GaugeVotesTableProps)
   // Get user proposal votes
   useEffect(() => {
     if (!gaugeVotesMapper[gaugeAddress] && gaugeVotesLoading && !gaugeVotesError) {
-      void getGaugeVotes(gaugeAddress)
+      getGaugeVotes(gaugeAddress).catch(errorFallback)
     }
   }, [getGaugeVotes, gaugeAddress, gaugeVotesLoading, gaugeVotesError, gaugeVotesMapper])
 

apps/main/src/dao/components/PageGauges/GaugeListItem/SmallScreenCard.tsx

@@ -12,6 +12,7 @@ import Spinner, { SpinnerWrapper } from '@ui/Spinner'
 import { t } from '@ui-kit/lib/i18n'
 import { DAO_ROUTES } from '@ui-kit/shared/routes'
 import { formatNumber } from '@ui-kit/utils'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import VoteGaugeField from '../GaugeVoting/VoteGaugeField'
 import GaugeDetailsSm from './GaugeDetailsSm'
 import TitleComp from './TitleComp'
@@ -45,7 +46,7 @@ const SmallScreenCard = ({
 
   useEffect(() => {
     if (open && !gaugeWeightHistoryMapper[gaugeData.address]) {
-      void getHistoricGaugeWeights(gaugeData.address)
+      getHistoricGaugeWeights(gaugeData.address).catch(errorFallback)
     }
   }, [gaugeData.address, gaugeWeightHistoryMapper, getHistoricGaugeWeights, open])
 
@@ -115,7 +116,7 @@ const SmallScreenCard = ({
                   message={t`Error fetching historical gauge weights data`}
                   onClick={(e?: MouseEvent) => {
                     e?.stopPropagation()
-                    void getHistoricGaugeWeights(gaugeData.address)
+                    getHistoricGaugeWeights(gaugeData.address).catch(errorFallback)
                   }}
                 />
               </ErrorWrapper>

apps/main/src/dao/components/PageGauges/GaugeListItem/index.tsx

@@ -19,6 +19,7 @@ import IconButton from '@ui/IconButton'
 import Spinner, { SpinnerWrapper } from '@ui/Spinner'
 import { t } from '@ui-kit/lib/i18n'
 import { DAO_ROUTES } from '@ui-kit/shared/routes'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import { Chain } from '@ui-kit/utils/network'
 
 type Props = {
@@ -69,7 +70,7 @@ const GaugeListItem = ({
 
   useEffect(() => {
     if (open && !gaugeWeightHistoryMapper[gaugeData.address]) {
-      void getHistoricGaugeWeights(gaugeData.address)
+      getHistoricGaugeWeights(gaugeData.address).catch(errorFallback)
     }
   }, [gaugeData.address, gaugeWeightHistoryMapper, getHistoricGaugeWeights, open])
 
@@ -113,7 +114,7 @@ const GaugeListItem = ({
                   message={t`Error fetching historical gauge weights data`}
                   onClick={(e?: MouseEvent) => {
                     e?.stopPropagation()
-                    void getHistoricGaugeWeights(gaugeData.address)
+                    getHistoricGaugeWeights(gaugeData.address).catch(errorFallback)
                   }}
                 />
               </ErrorWrapper>

apps/main/src/dao/components/PageGauges/GaugeVoting/VoteGaugeField/index.tsx

@@ -9,6 +9,7 @@ import Button from '@ui/Button'
 import TooltipIcon from '@ui/Tooltip/TooltipIcon'
 import { convertToLocaleTimestamp, formatDate, formatNumber } from '@ui/utils'
 import { t } from '@ui-kit/lib/i18n'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import { Chain } from '@ui-kit/utils/network'
 import NumberField from './NumberField'
 
@@ -49,7 +50,7 @@ const VoteGaugeField = ({ powerUsed, userGaugeVoteData, userVeCrv, newVote = fal
 
   const handleCastVote = () => {
     if (!address) return
-    void castVote(address, gaugeAddress, power)
+    castVote(address, gaugeAddress, power).catch(errorFallback)
   }
 
   return (

apps/main/src/dao/components/PageProposal/index.tsx

@@ -19,6 +19,7 @@ import { useWallet } from '@ui-kit/features/connect-wallet'
 import { t } from '@ui-kit/lib/i18n'
 import { DAO_ROUTES } from '@ui-kit/shared/routes'
 import { copyToClipboard } from '@ui-kit/utils'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import BackButton from '../BackButton'
 import ProposalVoteStatusBox from '../ProposalVoteStatusBox'
 import UserBox from '../UserBox'
@@ -72,7 +73,7 @@ export const Proposal = ({ proposalId: rProposalId, network }: ProposalUrlParams
         setSnapshotVeCrv(signer, userAddress, proposal.block, rProposalId)
       }
 
-      void getVeCrv()
+      getVeCrv().catch(errorFallback)
     }
   }, [provider, rChainId, rProposalId, setSnapshotVeCrv, proposal?.block, snapshotVeCrv, userAddress])
 

apps/main/src/dao/components/PageUser/index.tsx

@@ -7,6 +7,7 @@ import Box from '@ui/Box'
 import { useWallet } from '@ui-kit/features/connect-wallet'
 import { t } from '@ui-kit/lib/i18n'
 import { TabsSwitcher, type TabOption } from '@ui-kit/shared/ui/TabsSwitcher'
+import { errorFallback } from '@ui-kit/utils/error.util'
 import UserGaugeVotesTable from './UserGaugeVotesTable'
 import UserHeader from './UserHeader'
 import UserLocksTable from './UserLocksTable'
@@ -51,14 +52,14 @@ const UserPage = ({ routerParams: { userAddress: rUserAddress } }: UserPageProps
 
   useEffect(() => {
     if (Object.keys(allHolders).length === 0 && holdersLoading && !holdersError) {
-      void getVeCrvHolders()
+      getVeCrvHolders().catch(errorFallback)
     }
   }, [getVeCrvHolders, allHolders, holdersLoading, holdersError])
 
   // Get user ENS
   useEffect(() => {
     if (!userMapper[userAddress] && provider) {
-      void getUserEns(userAddress)
+      getUserEns(userAddress).catch(errorFallback)
     }
   }, [getUserEns, userAddress, userMapper, provider])
 

apps/main/src/dao/components/PageVeCrv/components/FormLockCreate.tsx

@@ -22,6 +22,8 @@ import usePageVisibleInterval from '@ui-kit/hooks/usePageVisibleInterval'
 import dayjs from '@ui-kit/lib/dayjs'
 import { t } from '@ui-kit/lib/i18n'
 import { REFRESH_INTERVAL } from '@ui-kit/lib/model'
+import { errorFallback } from '@ui-kit/utils/error.util'
+import { useThrottle } from '@ui-kit/utils/timers'
 
 const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) => {
   const isSubscribed = useRef(false)
@@ -34,7 +36,7 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
   const formValues = useStore((state) => state.lockedCrv.formValues)
   const fetchStepApprove = useStore((state) => state.lockedCrv.fetchStepApprove)
   const fetchStepCreate = useStore((state) => state.lockedCrv.fetchStepCreate)
-  const setFormValues = useStore((state) => state.lockedCrv.setFormValues)
+  const setFormValues = useThrottle(useStore((state) => state.lockedCrv.setFormValues))
 
   const [steps, setSteps] = useState<Step[]>([])
   const [txInfoBar, setTxInfoBar] = useState<ReactNode>(null)
@@ -46,9 +48,9 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
   const maxUtcDate = dayjs.utc().add(4, 'year')
 
   const updateFormValues = useCallback(
-    (updatedFormValues: Partial<FormValues>, isFullReset?: boolean) => {
+    async (updatedFormValues: Partial<FormValues>, isFullReset?: boolean) => {
       setTxInfoBar(null)
-      setFormValues(curve, isLoadingCurve, rFormType, updatedFormValues, vecrvInfo, isFullReset)
+      await setFormValues(curve, isLoadingCurve, rFormType, updatedFormValues, vecrvInfo, isFullReset)
     },
     [curve, isLoadingCurve, vecrvInfo, rFormType, setFormValues],
   )
@@ -75,7 +77,7 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
           days,
         },
         false,
-      )
+      ).catch(errorFallback)
     },
     [currUtcDate, haveSigner, maxUtcDate, minUtcDate, rChainId, updateFormValues],
   )
@@ -87,15 +89,21 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
       if (!value || !unit) {
         const days = maxUtcDate.diff(currUtcDate, 'd')
         const calcdUtcDate = calcUnlockTime(curve, 'create', null, days)
-        updateFormValues({ utcDate: toCalendarDate(calcdUtcDate), utcDateError: '', days, calcdUtcDate: '' }, false)
+        updateFormValues(
+          { utcDate: toCalendarDate(calcdUtcDate), utcDateError: '', days, calcdUtcDate: '' },
+          false,
+        ).catch(errorFallback)
         return maxUtcDate
       }
 
       const utcDate = dayjs.utc().add(value, unit)
       const days = utcDate.diff(currUtcDate, 'd')
       const calcdUtcDate = calcUnlockTime(curve, 'create', null, days)
 
-      updateFormValues({ utcDate: toCalendarDate(calcdUtcDate), utcDateError: '', days, calcdUtcDate: '' }, false)
+      updateFormValues(
+        { utcDate: toCalendarDate(calcdUtcDate), utcDateError: '', days, calcdUtcDate: '' },
+        false,
+      ).catch(errorFallback)
       return utcDate
     },
     [currUtcDate, maxUtcDate, rChainId, updateFormValues],
@@ -185,7 +193,7 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
   // onMount
   useEffect(() => {
     isSubscribed.current = true
-    updateFormValues({}, true)
+    updateFormValues({}, true).catch(errorFallback)
 
     return () => {
       isSubscribed.current = false
@@ -223,7 +231,10 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
           haveSigner={haveSigner}
           formType={rFormType}
           vecrvInfo={vecrvInfo}
-          handleInpLockedAmt={useCallback((lockedAmt) => updateFormValues({ lockedAmt }, false), [updateFormValues])}
+          handleInpLockedAmt={useCallback(
+            (lockedAmt) => updateFormValues({ lockedAmt }, false).catch(errorFallback),
+            [updateFormValues],
+          )}
           {...formValues}
         />
 
@@ -254,7 +265,10 @@ const FormLockCreate = ({ curve, rChainId, rFormType, vecrvInfo }: PageVecrv) =>
 
       <FormActions haveSigner={haveSigner} loading={loading}>
         {formStatus.error && (
-          <AlertFormError errorKey={formStatus.error} handleBtnClose={() => updateFormValues({}, false)} />
+          <AlertFormError
+            errorKey={formStatus.error}
+            handleBtnClose={() => updateFormValues({}, false).catch(errorFallback)}
+          />
         )}
         {txInfoBar}
         <Stepper steps={steps} />