feat: add future rates to mint markets #1648
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DanielSchiavini
requested review from
0xAlunara,
0xPearce,
0xtutti and
OnlyJousting
0xAlunara
reviewed
Nov 13, 2025
| averageRate: averageRate, | ||
| averageRateLabel: averageMultiplierString, | ||
| rebasingYield: crvUsdSnapshots?.[crvUsdSnapshots.length - 1]?.collateralToken.rebasingYield ?? null, | ||
| rebasingYield: last(crvUsdSnapshots)?.collateralToken.rebasingYield ?? null, |
Collaborator
There was a problem hiding this comment.
May I introduce you to our lord and savior crvUsdSnapshots.at(-1)
| <Typography variant="tableCellMBold" color="textPrimary"> | ||
| {rate == null ? '—' : formatPercent(rate)} | ||
| {id === LlamaMarketColumnId.BorrowRate && market.rates.borrowFutureRate && ( | ||
| <> |
Collaborator
There was a problem hiding this comment.
I'd make this a <Stack direction="row" alignItems='center' gap={Spacing.xs}> (I guessed the spacing, maybe more or less looks better)
Looks kinda funky without
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.