Skip to content

Conversation

@cberthierVicat
Copy link
Contributor

Desired Outcome

I tried to get members in a safe with method list_safe_members(), but an error was raised when validate_python was called (line 164, services/pcloud/safes/ark_pcloud_safes_service.py).

After some investigations, I find a wrong name attribut in ArkPCloudSafeMember: is_expired_membership_enabled, I must replace by is_expired_membership_enable.

See the documentation API

Implemented Changes

I changed the attribut is_expired_membership_enabled to is_expired_membership_enable

Connected Issue/Story

No issue

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Copy link
Collaborator

@ofiriluz ofiriluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey

Thank you for the contribution, can you please bump the pyproject patch version?

@cberthierVicat
Copy link
Contributor Author

Hey

Thank you for the contribution, can you please bump the pyproject patch version?

Done !

@ofiriluz ofiriluz merged commit 9ac6f3f into cyberark:main Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants