Implement missing CRUD functionality #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s since we run into problems with delete and update if we don't. Implement insertion and deletion
This was
linked to
issues
Sep 17, 2025
Contributor
|
Should we mention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #2 the delete, update, insert, begin_modify and end_modify functions need to be implemented in order for writing to etcd to be possible. This has now been implemented.
#8 is now also implemented as the columns are now taken into account when begin_scan is called.
As for #12 it was a quick fix and also added here.
Summary:
EtcdFdw#2 fixed/implemented