Skip to content

Fix missed call notifications #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Fix missed call notifications #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
048c5b7
Add `CallSid` tag to missed call notifications
cybex-dev Sep 17, 2023
d1c748d
Update changelog
cybex-dev Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Next release

* Fix: [Web] Multiple missed call notifications

## 0.1.0

* Feat: [Android] Turn off the screen when a call is active and the head is against the handset. @solid-software (https://solid.software)
Expand Down
3 changes: 2 additions & 1 deletion lib/_internal/twilio_voice_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,12 +943,13 @@ class Call extends MethodChannelTwilioCall {
// TODO(cybex-dev) future actions
// {'action': 'callback', 'title': 'Return Call'},
];
final callSid = callParams["CallSid"] as String;

// show JS notification using SW
NotificationService.instance.showNotification(
action: action,
title: title,
tag: "",
tag: callSid,
body: body,
actions: actions,
requiresInteraction: true,
Expand Down