Skip to content

Fix openPhoneAccountSettings on Android #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix openPhoneAccountSettings on Android #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbccddf
fix: `openPhoneAccountSettings` using try/catch with fallback
cybex-dev Sep 18, 2023
bdd239f
Update changelog
cybex-dev Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Next release

* Fix: [Web] Multiple missed call notifications
* Fix: [Android] `openPhoneAccountsSettings` not always opening on various Android (mainly Samsung) devices

## 0.1.0

Expand Down
23 changes: 16 additions & 7 deletions android/src/main/kotlin/com/twilio/twilio_voice/types/TelecomManagerExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,22 @@ object TelecomManagerExtension {

fun TelecomManager.openPhoneAccountSettings(activity: Activity) {
if (Build.MANUFACTURER.equals("Samsung", ignoreCase = true)) {
val intent = Intent(TelecomManager.ACTION_CHANGE_PHONE_ACCOUNTS)
intent.component = ComponentName(
"com.android.server.telecom",
"com.android.server.telecom.settings.EnableAccountPreferenceActivity"
)
intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
activity.startActivity(intent, null)
try {
val intent = Intent(TelecomManager.ACTION_CHANGE_PHONE_ACCOUNTS)
intent.component = ComponentName(
"com.android.server.telecom",
"com.android.server.telecom.settings.EnableAccountPreferenceActivity"
)
intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
activity.startActivity(intent, null)
} catch (e: Exception) {
Log.e("TelecomManager", "openPhoneAccountSettings: ${e.message}")

// use fallback method
val intent = Intent(TelecomManager.ACTION_CHANGE_PHONE_ACCOUNTS)
activity.startActivity(intent, null)
}

} else {
val intent = Intent(TelecomManager.ACTION_CHANGE_PHONE_ACCOUNTS)
activity.startActivity(intent, null)
Expand Down