feat: enable new rules(no-import-assign, default-param-last, prefer-regex-literals)

BREAKING CHANGE: enable no-import-assign, default-param-last, prefer-regex-literals rules

Author: koba04

lib/base.js

@@ -16,6 +16,7 @@ module.exports = {
     // =======
 
     // Best Practices
+    "default-param-last": "error",
     "no-caller": "error",
     "no-eval": "error",
     "no-extend-native": "error",
@@ -43,6 +44,7 @@ module.exports = {
     "no-useless-concat": "error",
     "no-void": "error",
     "no-with": "error",
+    "prefer-regex-literals": "error",
     radix: "error",
     "wrap-iife": ["error", "any"],
     // no-case-declarations
@@ -57,6 +59,7 @@ module.exports = {
     // Possible Errors
     "no-async-promise-executor": "error",
     "no-extra-parens": ["error", "functions"],
+    "no-import-assign": "error",
     "require-atomic-updates": "error",
     "valid-typeof": [
       "error",

test/base-test.js

@@ -13,8 +13,11 @@ describe("base", () => {
           "no-redeclare",
           "getter-return",
           "no-self-assign",
+          "no-import-assign",
           "require-atomic-updates",
-          "no-async-promise-executor"
+          "no-async-promise-executor",
+          "default-param-last",
+          "prefer-regex-literals"
         ],
         warnings: ["no-useless-return"]
       },

test/fixtures/base/error.js

@@ -1,3 +1,5 @@
+import mod from './mod';
+
 var foo = {};
 var foo = {};
 const obj = {
@@ -9,6 +11,18 @@ const obj = {
 
 obj.a = obj.a;
 
+mod = 'mod';
+console.log(mod);
+
 (async () => {
   obj.a += await new Promise(async (r) => r(10));
-})();
+})();
+
+function fn(a, b = 'b', c) {
+  // noop
+}
+fn();
+
+const regexp = new RegExp('foo|bar');
+console.log(regexp);
+