feat: add cybozu/eslint-config/presets/node and presets/node-prettier (#44)

Author: koba04

README.md

@@ -83,6 +83,16 @@ module.exports = {
 };
 ```
 
+### `@cybozu/eslint-config/node`
+
+This rule set is for projects running on a Node environment.
+
+```js
+module.exports = {
+  extends: "@cybozu/eslint-config/presets/node"
+};
+```
+
 ### [Experimental] `@cybozu/eslint-config/presets/react`
 
 This rule set is for projects using React, which has JSX support and rules related React provided by `eslint-plugin-react` and `eslint-plugin-jsx-ally`.
@@ -147,6 +157,7 @@ In order to this, you have to install `prettier` and choose a preset from the fo
 ```
 
 - `@cybozu/eslint-config/presets/prettier`
+- `@cybozu/eslint-config/presets/node-prettier`
 - `@cybozu/eslint-config/presets/react-prettier`
 - `@cybozu/eslint-config/presets/react-flowtype-prettier`
 - `@cybozu/eslint-config/presets/es5-prettier`

lib/node.js

@@ -0,0 +1,6 @@
+module.exports = {
+  extends: ["plugin:node/recommended"],
+  rules: {
+    "no-console": "off"
+  }
+};

package-lock.json

@@ -28,6 +28,7 @@
   "license": "MIT",
   "devDependencies": {
     "eslint": "^5.6.0",
+    "eslint-plugin-node": "^7.0.1",
     "mocha": "^5.2.0",
     "npm-run-all": "^4.1.3",
     "prettier": "^1.14.3",

package.json

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: ["../lib/base.js", "../lib/node.js", "../lib/prettier.js"]
+};

presets/node-prettier.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: ["../lib/base.js", "../lib/node.js"]
+};

presets/node.js

@@ -0,0 +1,5 @@
+require('./unknown');
+
+(async () => {
+  await new Promise(r => r);
+})();

test/fixtures/node/error.js

@@ -0,0 +1,3 @@
+const path = require('path');
+
+console.log(path.resolve(__dirname));

test/fixtures/node/ok.js

@@ -0,0 +1,17 @@
+const assert = require("assert");
+const runLintWithFixtures = require("./lib/runLintWithFixtures");
+
+describe("node", () => {
+  it("should get expected errors and warninigs with node config", () => {
+    const result = runLintWithFixtures("node");
+    assert.deepStrictEqual(result, {
+      "error.js": {
+        errors: [
+          "node/no-missing-require",
+          "node/no-unsupported-features/es-syntax"
+        ]
+      },
+      "ok.js": {}
+    });
+  });
+});

test/node-test.js

@@ -45,6 +45,31 @@ describe("presets", () => {
       );
     });
   });
+  describe("node", () => {
+    it("should be able to use node as well as lib/node", () => {
+      assert.deepStrictEqual(
+        runLintWithFixtures("node"),
+        runLintWithFixtures("node", "presets/node.js")
+      );
+    });
+  });
+  describe("kintone-customize-es5", () => {
+    it("should be able to use kintone-customize-es5 as well as lib/es5 and lib/kintone", () => {
+      assert.deepStrictEqual(
+        runLintWithFixtures("es5"),
+        runLintWithFixtures("es5", "presets/kintone-customize-es5.js")
+      );
+    });
+    it("should be able to use kintone-customize-es5 as well as lib/kintone", () => {
+      assert.deepStrictEqual(
+        runLintWithFixtures("kintone", "presets/kintone-customize-es5.js"),
+        {
+          "ok.js": {},
+          "error.js": { errors: ["strict", "strict"] }
+        }
+      );
+    });
+  });
   describe("prettier", () => {
     it("should be able to use prettier as well as lib/prettier", () => {
       assert.deepStrictEqual(
@@ -69,20 +94,11 @@ describe("presets", () => {
       );
     });
   });
-  describe("kintone-customize-es5", () => {
-    it("should be able to use kintone-customize-es5 as well as lib/es5 and lib/kintone", () => {
+  describe("node-prettier", () => {
+    it("should be able to use node-prettier as well as lib/prettier", () => {
       assert.deepStrictEqual(
-        runLintWithFixtures("es5"),
-        runLintWithFixtures("es5", "presets/kintone-customize-es5.js")
-      );
-    });
-    it("should be able to use kintone-customize-es5 as well as lib/kintone", () => {
-      assert.deepStrictEqual(
-        runLintWithFixtures("kintone", "presets/kintone-customize-es5.js"),
-        {
-          "ok.js": {},
-          "error.js": { errors: ["strict", "strict"] }
-        }
+        runLintWithFixtures("prettier"),
+        runLintWithFixtures("prettier", "presets/node-prettier.js")
       );
     });
   });