convert dependencies to peerDependencies #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging cyclejs/react#5, npm started to create `node_modules/@cycle/react-dom/node_modules/@cycle`, because cyclejs/react-dom currently depends on cyclejs/react-dom v2.1.0, which in turns depends on React 16.5.2... This PR is for fixing the same issue - avoid nested npm installs of peer dependencies.
Contributor
Author
|
Instead of updating the peer version of |
Member
|
Thanks! |
Contributor
Author
|
Thanks, it works perfectly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging cyclejs/react#5, npm started to create
node_modules/@cycle/react-dom/node_modules/@cyclewith the old stuff (react-dom/node_modules/@cycle/react/node_modules...), becausecyclejs/react-domcurrently depends on cyclejs/react-dom v2.1.0, which in turn depends on React 16.5.2... This PR is for fixing the same issue - avoid nested npm installs of peer dependencies.