Add unit tests for StudentManager#16
Merged
swaparup36 merged 3 commits intocyclohexane-2:mainfrom Dec 9, 2025
Merged
Conversation
swaparup36
requested changes
Dec 7, 2025
Contributor
swaparup36
left a comment
swaparup36
left a comment
There was a problem hiding this comment.
Consider grouping related tests in classes and use @pytest.fixture for common setup. Moreover -
- Add some more testcases for edge cases - like with negative values, empty strings or values outside the boundary.
- Write tests for past deadline scenarios.
- Add test cases for duplicate and non-existent data
- Consider empty collection operations
Contributor
Author
|
Hi! Please review again. |
Contributor
|
@Rathore-tech-code Good job! Just few more test cases like on |
Contributor
Author
|
Added requested tests (None title + past deadline). |
Contributor
|
LGTM. Nice work. thanks! |
swaparup36
approved these changes
Dec 9, 2025
xenonnn4w
reviewed
Feb 12, 2026
| "Old HW", past_deadline, "History" | ||
| ) | ||
|
|
||
| assert assignment in student_manager.assignments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds unit tests for the StudentManager class.
What was added
✔ Tests for adding assignments
✔ Tests for marking assignments as completed
✔ GPA calculation validation
✔ Invalid grade handling (raises ValueError)
✔ Student statistics calculation
Result
All tests pass successfully using
python -m pytest.Fixes #6
Please review and merge 😊